Fix bug in URL rewriting policy that makes it ignore a field of its own manifest [THREESCALE-731] #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikz
changed the title
The code was not taking into account that there's a `commands` attribute in the manifest.
davidor
force-pushed
the
fix-bug-respect-manifest-url-rewriting
branch
from
f45f793 to
9d7e809
Compare
davidor
force-pushed
the
fix-bug-respect-manifest-url-rewriting
branch
from
9d7e809 to
fa5cb61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in the URL rewriting policy.
The problem was that there was a
commandsattribute specified in the policy manifest, but we did not include it in the configuration used in the busted tests nor the integration tests. The policy ignored this attribute and that's why the tests were passing. This suggests that we need to validate configs against manifests when instantiating policies. I'm working on that and will open a new PR once it's ready.Ref: https://issues.jboss.org/browse/THREESCALE-731