Validation for policy configurations #646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidor
force-pushed
the
validate-policy-configs
branch
from
277976d to
7d4316d
Compare
davidor
force-pushed
the
validate-policy-configs
branch
from
7d4316d to
eb3b396
Compare
'ljsonschema' uses the draft-04 version of the JSON schema. 'const' was introduced later and so we can't use them. An enum of 1 element is mostly equivalent and a valid option for our use case.
davidor
force-pushed
the
validate-policy-configs
branch
from
eb3b396 to
b4d827c
Compare
davidor
changed the title
|
There have been a few changes:
|
mikz
reviewed
Mar 7, 2018
t/apicast-policy-invalid-config.t
Outdated
| --- request | ||
| GET /?user_key=value | ||
| --- error_code: 200 | ||
| --- must_die |
There was a problem hiding this comment.
The must die signals nginx should quit, right? does it need the --- backend and upstream then? And the error_code ?
There was a problem hiding this comment.
You're right. These are leftovers because at first, I was logging an error instead of exiting.
Now we have a way to check that we do not use invalid policy configs in tests.
We only want to use this option in tests.
davidor
force-pushed
the
validate-policy-configs
branch
from
2305484 to
8c2df39
Compare
mikz
approved these changes
Mar 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a way to validate a policy's configuration against the JSON schema defined for its configuration.
This is what I used to detect the problems in our tests fixed in previous PRs: #641 , #644 , #645
We need to define and agree on a few things before this becomes mergeable. That's why I tagged it as WIP:
rapidjsonto perform the validation, and it needs cmake. This means that it should be installed on the base image.rapidjsonuses the draft04 version of the JSON schema. I needed to replace theconsts in our schemas so it works correctly asconstwas introduced in newer versions.