introduce test block #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A test block can nginx config for a location to be executed by the test request. The test does not have to define request as it will be automatically set to point to the test block. See an example: https://github.com/3scale/apicast/blob/9288d0d1e9b059cb10ef81a99c475d8b817d449c/t/listen-https.t#L18-L39 Test::Nginx can't make HTTPS requests, so we need some workaround to call APIcast with HTTPS. lua-nginx-module does the same: https://github.com/openresty/lua-nginx-module/blob/36f341e72858a6dfb861ceb3fbe548b690006acf/t/139-ssl-cert-by.t
davidor
approved these changes
Jun 5, 2018
mikz
added a commit
to 3scale/APIcast
that referenced
this pull request
Jun 5, 2018
includes 3scale/Test-APIcast#9 includes 3scale/Test-APIcast#10
mikz
added a commit
to 3scale/APIcast
that referenced
this pull request
Jun 6, 2018
includes 3scale/Test-APIcast#9 includes 3scale/Test-APIcast#10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A test block can nginx config for a location to be executed by the test request.
The test does not have to define request as it will be automatically
set to point to the test block.
See an example: https://github.com/3scale/apicast/blob/9288d0d1e9b059cb10ef81a99c475d8b817d449c/t/listen-https.t#L18-L39
Test::Nginx can't make HTTPS requests, so we need some workaround to
call APIcast with HTTPS. lua-nginx-module does the same: https://github.com/openresty/lua-nginx-module/blob/36f341e72858a6dfb861ceb3fbe548b690006acf/t/139-ssl-cert-by.t