metrics: rename backend_response to threescale_backend_response #917
Conversation
So it's not confused with the upstream API
davidor
force-pushed
the
rename-backend-response-metric
branch
from
0941654 to
f4c754b
Compare
| @@ -7,7 +7,7 @@ local _M = {} | |||
|
|
|||
| local backend_response_metric = prometheus( | |||
| 'counter', | |||
| 'backend_response', | |||
| 'threescale_backend_response', | |||
There was a problem hiding this comment.
Can they start with a number? threescale should be the last resort how to write3scale
There was a problem hiding this comment.
no, that's why I chose threescale :D
There was a problem hiding this comment.
Sigh :( I really don't like it. Do we have any alternatives? Like prefixing it with something? If no, then let's merge it.
There was a problem hiding this comment.
Hmm we might want to prefix all our metrics with apicast. That would solve the issue.
There was a problem hiding this comment.
That does not sound that bad. I'm fine with both.
There was a problem hiding this comment.
I'll add the apicast prefix. I think it makes sense if we take into account that other apps can export metrics to the same Prometheus instance. Also, it's recommended in the Prometheus guidelines: https://prometheus.io/docs/practices/naming/
To clearly distinguish it from the upstream API as suggested in #745 (comment)