Improve rate limit policy #679
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikz
reviewed
Apr 24, 2018
| @@ -10,6 +10,10 @@ local limit_traffic = require "resty.limit.traffic" | |||
| local ts = require ('apicast.threescale_utils') | |||
| local tonumber = tonumber | |||
| local next = next | |||
| local format = string.format | |||
| local insert = table.insert | |||
| local os_date = os.date | |||
There was a problem hiding this comment.
Better to use ngx.time or ngx.now as they are way more performant in scope of OpenResty.
mikz
reviewed
Apr 24, 2018
| @@ -234,6 +234,7 @@ describe('Rate limit policy', function() | |||
| assert.equal('10', window) | |||
|
|
|||
| os.execute("sleep 1") | |||
There was a problem hiding this comment.
Haven't noticed this earlier. There is ngx.sleep() that is better than spawning a subprocess.
y-tabata
force-pushed
the
improve-rate-limit-policy
branch
from
57a3255 to
d2ee92a
Compare
y-tabata
force-pushed
the
improve-rate-limit-policy
branch
from
9c49ac2 to
feae81d
Compare
|
@mikz The |
|
@y-tabata The error has nothing to do with your PR, sorry. |
|
@mikz Sure, no problem. |
|
move to #703 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the rate limit policy according to the comments of PR #665 and addresses to Issue #667.