Fix image tag in s2i-builder circle CI job #666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem is that in PRs, `CIRCLE_BRANCH` includes a '/'. For example, for PR 567, it equals `pull/567`. That's an issue because in Docker, tags cannot contain '/'. This commits fixes the issue by using only the PR number.
davidor
force-pushed
the
fix-image-tag-s2i-builder-job
branch
from
0d65014 to
50ce8ba
Compare
davidor
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The circle CI job
s2i-builderis failing in PRs. See #665 , for example.The problem is that in PRs we're trying to create a docker image using an invalid tag.
CIRCLE_BRANCHincludes a '/'. For example, for PR 567, it equalspull/567, and we are using it as a tag. That's an issue because, in Docker, tags cannot contain '/'.This commits fixes the issue by using only the PR number.
If the
s2i-buildercheck passes in this PR, it means that the issue is solved.