[proxy] split proxy:call() into rewrite and access phase #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikz
force-pushed
the
proxy-split-rewrite-access
branch
2 times, most recently
from
a5e1346 to
78d3ed4
Compare
Merged
davidor
reviewed
Jan 31, 2018
gateway/src/apicast/proxy.lua
Outdated
| service = _M.set_service(service or ngx.ctx.service) | ||
|
|
||
| self.oauth = service:oauth() | ||
| function _M:handle_oauth(service) |
There was a problem hiding this comment.
I think we should make this local
There was a problem hiding this comment.
Yeah, probably hood idea.
mikz
commented
Jan 31, 2018
gateway/src/apicast/proxy.lua
Outdated
| self.oauth = service:oauth() | ||
| function _M:handle_oauth(service) | ||
| local oauth = service:oauth() | ||
| self.oauth = oauth |
There was a problem hiding this comment.
Maybe this assignment is not needed then.
There was a problem hiding this comment.
It is, unless we change something.
There's self.oauth:transform_credentials at the end of rewrite().
We should check if it's possible to move that block of code to handle_oauth.
There was a problem hiding this comment.
Yep. It was needed for transform_credentials. Now it returns oauth and is assigned in the :rewrite.
|
Looks good 👍 |
mikz
force-pushed
the
proxy-split-rewrite-access
branch
from
78d3ed4 to
d59864b
Compare
mikz
changed the title
mikz
force-pushed
the
proxy-split-rewrite-access
branch
from
d59864b to
65424b7
Compare
davidor
reviewed
Jan 31, 2018
| @@ -61,7 +29,7 @@ describe('Proxy', function() | |||
| service.credentials = { location = 'headers' } | |||
| service.backend_version = 2 | |||
| ngx.var.http_app_key = 'key' | |||
| assert.falsy(proxy:access(service)) | |||
| assert.falsy(proxy:rewrite(service)) | |||
There was a problem hiding this comment.
kind of strange to find rewrite() in describe(':access')
davidor
approved these changes
Jan 31, 2018
so policies can change the context to add credentials/usage before the authorize call to 3scale backend
mikz
force-pushed
the
proxy-split-rewrite-access
branch
from
65424b7 to
6000cf0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #495
This allows policy authors to modify
usagein the rewrite phase as it is being used later in theaccessphase. That can be used to for example report custom metrics matched by the policy.