-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HTTP Cache support to http_ng #357
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
cb3a283
[http] change backend interface to pass the backend instance
mikz bb69f13
[spec] fake http backend allows custom response
mikz 0a1a9f7
[http] experimental cache store
mikz ddda6d9
[http] improve handling http headers
mikz 04401a9
[http] request defaults to 1.1
mikz 7cfa8af
[http] response has to have a date
mikz 7f3b0a5
[http] implement revalidation
mikz d6b76e7
[spec] fix keycloak tests missing Date header
mikz 7ca62a6
[http] cleanup to fix luacheck errors
mikz 41c2564
[http] test cache store with test backend
mikz 008f5a8
[http] set default cache size to 100 entries
mikz 4e1067d
[changelog] mention http cache
mikz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
local setmetatable = setmetatable | ||
|
||
------------ | ||
--- HTTP | ||
-- HTTP client | ||
-- @module http_ng.backend | ||
|
||
local _M = {} | ||
|
||
local mt = { __index = _M } | ||
|
||
function _M.new(backend, options) | ||
local opts = options or {} | ||
return setmetatable({ | ||
backend = backend, cache_store = opts.cache_store | ||
}, mt) | ||
end | ||
|
||
--- Send request and return the response | ||
-- @tparam http_ng.request request | ||
-- @treturn http_ng.response | ||
function _M:send(request) | ||
local cache_store = self.cache_store | ||
local backend = self.backend | ||
|
||
local response, err | ||
|
||
if cache_store then | ||
response, err = cache_store:send(backend, request) | ||
else | ||
response, err = backend:send(request) | ||
end | ||
|
||
return response, err | ||
end | ||
|
||
return _M |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the difference between
:
and.
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hah!
:
is syntactic sugar for passing self.So these are the same code:
This works in the function definition too:
Passing
self
It is the only way how a function can know about the object being called on. Like instance method. Otherwise it does not really have any state other than a closure.