Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid throwing an error when there is no cached proxy object #302

Closed
wants to merge 1 commit into from

Conversation

mayorova
Copy link
Contributor

In case the API call doesn't pass thought the access phase (typical case would be if it is an /authorize or /oauth/token, or if the service is not found, so the exit is done in the rewrite phase), an error will be thrown in post_action:

2017/03/15 05:09:43 [error] 31748#0: *2 lua entry thread aborted: runtime error: .../apicast.lua:70: attempt to index local 'p' (a nil value)

Not sure if we also need to print some warning in the log in this case.

@octobot
Copy link

octobot commented Mar 14, 2017

1 Error
🚫 Please include a CHANGELOG entry.
You can find it at CHANGELOG.md.
1 Message
📖 Note, we hard-wrap at 80 chars and use 2 spaces after the last line.

Generated by 🚫 Danger

@mikz
Copy link
Contributor

mikz commented Mar 14, 2017

This is fixed in #290 and thanks for explaining when it happens.
I'll write a test case for it.

@mikz mikz closed this Mar 14, 2017
@mikz mikz mentioned this pull request Mar 14, 2017
1 task
mikz added a commit that referenced this pull request Mar 15, 2017
@mikz mikz deleted the fix-missing-proxy-var branch March 15, 2017 06:52
@mikz
Copy link
Contributor

mikz commented Mar 15, 2017

Regression test pushed as ca45731

mikz added a commit that referenced this pull request Mar 16, 2017
mikz added a commit that referenced this pull request Mar 16, 2017
mikz added a commit that referenced this pull request Mar 17, 2017
mikz added a commit that referenced this pull request Mar 17, 2017
mikz added a commit that referenced this pull request Mar 20, 2017
mikz added a commit that referenced this pull request Mar 20, 2017
mikz added a commit that referenced this pull request Mar 20, 2017
mikz added a commit that referenced this pull request Mar 20, 2017
mikz added a commit that referenced this pull request Mar 20, 2017
mikz added a commit that referenced this pull request Mar 20, 2017
mikz added a commit that referenced this pull request Mar 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants