Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinstall http module to dev/ci image #1531

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Conversation

tkan145
Copy link
Contributor

@tkan145 tkan145 commented Jan 29, 2025

What

Http/2 tests failed in #1523 this due to we removed http and luaossl modules when migrating to lua-resty-openssl

Verification steps

  • Checkout this branch
  • Build a new dev-image
make dev-build IMAGE_NAME=apicast-dev
  • Start development env
make development IMAGE=apicast-dev
  • Run http/2 test
make prove PROVE_FILES=./t/apicast-http2.t
  • All tests should pass

Previously removed when migrating to lua-resty-openssl, but it is needed
for http/2 test.
@tkan145 tkan145 requested a review from a team as a code owner January 29, 2025 04:27
@tkan145 tkan145 merged commit 65127c0 into 3scale:master Jan 29, 2025
14 checks passed
@tkan145 tkan145 deleted the ci-image-http2 branch January 29, 2025 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants