-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add APICAST_ACCESS_LOG_BUFFER option #1248
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidor
approved these changes
Jan 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Do you have any numbers? Just to get an idea about the perf gains that a log buffer of 1K or 4K for example gives.
porueesq
reviewed
Jan 11, 2021
porueesq
reviewed
Jan 11, 2021
porueesq
reviewed
Jan 11, 2021
porueesq
suggested changes
Jan 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions.
b225e76
to
6326c2c
Compare
porueesq
approved these changes
Jan 11, 2021
This commit add a new way to write access log, based on chunks, so access log writes only happens when a buffer is full and this improves the performance by reducing the number of system calls. Fix THREESCALE-6563 Signed-off-by: Eloy Coto <eloy.coto@acalustra.com>
Co-authored-by: porueesq <43811485+porueesq@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit add a new way to write access log, based on chunks, so
access log writes only happens when a buffer is full and this improves the
performance by reducing the number of system calls.
Signed-off-by: Eloy Coto eloy.coto@acalustra.com