Policy:3scale_batcher: Fix issues when caching policy is active. #1216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidor
reviewed
Aug 17, 2020
t/apicast-policy-3scale-batcher.t
Outdated
| @@ -615,3 +615,79 @@ my $jwt = encode_jwt(payload => { | |||
| ["Authorization: Bearer $jwt", "Authorization: Bearer $jwt", "" , ""] | |||
| --- no_error_log | |||
| [error] | |||
|
|
|||
|
|
|||
| === TEST 6: with caching policy (allow mode) | |||
t/apicast-policy-3scale-batcher.t
Outdated
| In this case, the caching policy is configured as "allow". We define a | ||
| backend that returns 500 | ||
| The caching policy will allow all request to the Upstream API. | ||
| down. |
There was a problem hiding this comment.
It looks like this line is misplaced.
| @@ -143,6 +143,14 @@ local function handle_backend_denied(self, service, transaction, status, headers | |||
| return error(service, rejection_reason) | |||
| end | |||
|
|
|||
| local function handle_backend_response_using_cache_handler(cache, transaction, backend_status, cache_handler) | |||
There was a problem hiding this comment.
This looks almost the same as the existing update_downtime_cache function.
eloycoto
force-pushed
the
THREESCALE-5753
branch
from
66d7665 to
79c9627
Compare
davidor
approved these changes
Aug 20, 2020
A user reported that when the caching mode is enabled, in allow mode, and 3scale-batcher is active, the handler for allowing all calls is no working as expected, and users got 403 response. This commit allows users to get a correct authz when allow mode is enabled. Fix THREESCALE-5753 Signed-off-by: Eloy Coto <eloy.coto@acalustra.com>
eloycoto
force-pushed
the
THREESCALE-5753
branch
from
79c9627 to
4511ed3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user reported that when the caching mode is enabled, in allow mode, and 3scale-batcher is active, the handler for allowing all calls is no working as expected, and users got 403 response.
This commit allows users to get a correct authz when allow mode is enabled.
Fix THREESCALE-5753
Signed-off-by: Eloy Coto eloy.coto@acalustra.com