Proxy Protocol support #1211
Merged
Proxy Protocol support #1211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
eloycoto
force-pushed
the
test_proxy_protocol
branch
from
c25e6ef to
7bcba3a
Compare
davidor
approved these changes
Jul 9, 2020
CHANGELOG.md
Outdated
| @@ -29,6 +29,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/). | |||
| - New content_caching Prometheus metric [THREESCALE-5439](https://issues.jboss.org/browse/THREESCALE-5439) [PR #1203](https://github.com/3scale/APIcast/pull/1203) | |||
|
|
|||
| - Added Camel policy [PR #1193](https://github.com/3scale/APIcast/pull/1193) [THREESCALE-4867](https://issues.jboss.org/browse/THREESCALE-4867) | |||
| - Support Proxy Protocol [PR #1195](https://github.com/3scale/APIcast/pull/1195) [THREESCALE-5366](https://issues.redhat.com/browse/THREESCALE-5366) | |||
There was a problem hiding this comment.
The github link needs to be updated.
Co-authored-by: dfennessy <44813955+dfennessy@users.noreply.github.com>
Signed-off-by: Eloy Coto <eloy.coto@acalustra.com>
Signed-off-by: Eloy Coto <eloy.coto@acalustra.com>
eloycoto
force-pushed
the
test_proxy_protocol
branch
from
7bcba3a to
ec4baa8
Compare
porueesq
reviewed
Jul 10, 2020
| use lib 't'; | ||
| use Test::APIcast::Blackbox 'no_plan'; | ||
|
|
||
| # These test are a bit difficult to understand. Due to the Nginx is set to listen |
There was a problem hiding this comment.
Suggested change
| # These test are a bit difficult to understand. Due to the Nginx is set to listen | |
| # Due to the Nginx is set to listen |
porueesq
reviewed
Jul 10, 2020
porueesq
suggested changes
Jul 10, 2020
Co-authored-by: porueesq <43811485+porueesq@users.noreply.github.com>
porueesq
approved these changes
Jul 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1194.
This is the same as PR #1195 but with integration test.