Policy: Camel proxy #1193
Merged
Policy: Camel proxy #1193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidor
reviewed
Jun 17, 2020
t/apicast-policy-camel.t
Outdated
|
|
||
| __DATA__ | ||
|
|
||
| === TEST 1: API backend connection uses proxy |
There was a problem hiding this comment.
Should this say "http proxy" to differentiate it from the other 2 tests?
| @@ -0,0 +1,77 @@ | |||
| # Camel proxy policy | |||
There was a problem hiding this comment.
Not sure if this is the best name for the policy. There's nothing camel-specific, it's valid for any proxy, right?
There was a problem hiding this comment.
The TLS is only for camel (With termination) and the policy name is suggested to be like that:
https://issues.redhat.com/browse/THREESCALE-4867
t/apicast-policy-camel.t
Outdated
|
|
||
| require("http_proxy.pl"); | ||
|
|
||
| repeat_each(3); |
|
|
||
| function _M:export() | ||
| return { | ||
| get_http_proxy = function(uri) |
There was a problem hiding this comment.
I think it'd be good to document here who expects this function to be in the context.
eloycoto
force-pushed
the
TLS_CAMEL_PROXY
branch
from
7968e53 to
fc39751
Compare
Camel netty proxy was used via http-proxy policy, but on TLS connections, the CONNECT method[0] is not allowed, so the request needs to be terminated by camel-proxy and send to the upstream API. With this change, we duplicate the http-proxy and we set the proxy to terminate the connection so that will work correctly on camel TLS connections. [0] https://www.ietf.org/rfc/rfc2817.txt Fix THREESCALE-4867 Signed-off-by: Eloy Coto <eloy.coto@acalustra.com>
eloycoto
force-pushed
the
TLS_CAMEL_PROXY
branch
from
fc39751 to
675e329
Compare
davidor
approved these changes
Jun 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Camel netty proxy was used via http-proxy policy, but on TLS
connections, the CONNECT method[0] is not allowed, so the request needs
to be terminated by camel-proxy and send to the upstream API.
With this change, we duplicate the http-proxy and we set the proxy to
terminate the connection so that will work correctly on camel TLS
connections.
[0] https://www.ietf.org/rfc/rfc2817.txt
Fix THREESCALE-4867
Signed-off-by: Eloy Coto eloy.coto@acalustra.com