GRPC policy: Fix routing upstream issue. #1179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This issue has test coverage on QE framework. @jsmadis |
This commit makes things super simpler in GRPC, and avoid the miss-configuration that was made previously around upstream&balancers. Before on GRPC we set the balancer, and all the balancer logic happened on the policy itself, instead of using the apicast.upstream and apicast.balancer. With this change, the location is changed on the upstream.lua, so it does not matter if was set in the apicast.policy, or in another policy, in this case the routing policy. This finally fix THREESCALE-4684 Signed-off-by: Eloy Coto <eloy.coto@gmail.com>
|
davidor
approved these changes
Mar 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes things super simpler in GRPC, and avoid the
miss-configuration that was made previously around upstream&balancers.
Before on GRPC we set the balancer, and all the balancer logic happened
on the policy itself, instead of using the apicast.upstream and
apicast.balancer.
With this change, the location is changed on the upstream.lua, so it
does not matter if was set in the apicast.policy, or in another policy,
in this case the routing policy.
This finally fix THREESCALE-4684
Signed-off-by: Eloy Coto eloy.coto@gmail.com