[THREESCALE-3189] Add maintenance policy #1105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eloycoto
approved these changes
Aug 6, 2019
davidor
force-pushed
the
add-maintenance-policy
branch
from
d2d309d to
f0cb126
Compare
mikz
reviewed
Aug 6, 2019
|
|
||
| if configuration then | ||
| policy.status_code = tonumber(configuration.status) or policy.status_code | ||
| policy.message = configuration.message or policy.message |
There was a problem hiding this comment.
It might be useful to also set some header in case this is active. So you can have the payload as JSON for example.
There was a problem hiding this comment.
Not sure what you mean by setting a header here.
Do you mean returning JSON or plain text according to the value of the Accept header of the request?
There was a problem hiding this comment.
I mean setting also Content-Type header when the policy is active. JSON payload is incorrect without proper Content-Type. And using two policies to activate mantenance mode would be weird.
mikz
reviewed
Aug 6, 2019
mikz
approved these changes
Aug 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new simple policy that allows users to reject incoming requests with a specified status code and message. It's useful for maintenance periods or to temporarily block an API.
This continues the work started by @alanmoran in #561
I used his commits, converted the policy to a builtin one (it was an example), and polished a few things and added some tests.