[THREESCALE-2896] Allow to define order restrictions in policies #1088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two reasons for this: 1) Now logs show the correct version when printing the policy chain. 2) In order to verify the order of policies in the chain, we need the real version in the policy instance. We need "builtin" which is what appears in the schema instead of the 0.0 that's set by default.
Also bump the version in the id.
And also point to the new version of the manifest (v1.1)
eloycoto
approved these changes
Jul 8, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the option to specify order restrictions between policies. When those restrictions are not respected, APIcast shows a warning.
This PR adds a new field in the manifest of policies to define the policies that should be placed after or before a specific one. With this information in the policy schema, Porta will be able to show warnings in the UI when building policy chains with policies placed in the incorrect order. For now, APIcast logs an error.
Ref: https://issues.jboss.org/browse/THREESCALE-2896