[THREESCALE-2755] Return "auth failed" instead of "limits exceeded" for disabled metrics #1066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikz
approved these changes
Jun 11, 2019
eloycoto
reviewed
Jun 11, 2019
gateway/src/apicast/proxy.lua
Outdated
| -- This header is set only when enabled via the '3scale-options' header of the | ||
| -- request. | ||
| local function limit_max_value(response_headers) | ||
| return response_headers and response_headers['3scale-limit-max-value'] |
There was a problem hiding this comment.
I would change here to return tonumber(response_headers['3scale-limit-max-value'])
There was a problem hiding this comment.
It would still need to be tonumber(response_headers and response_headers['3scale-limit-max-value']).
gateway/src/apicast/proxy.lua
Outdated
| -- APIcast, we want to distinguish between limits exceeded vs disabled | ||
| -- metric. That's why we reset the reason. The generic auth fail (403) will | ||
| -- be returned. | ||
| if tonumber(limit_max) == 0 and unauthorized_reason == 'limits_exceeded' then |
There was a problem hiding this comment.
If we return the number in the limit_max_value, here tonumber is not needed at all.
davidor
force-pushed
the
disabled-metrics
branch
from
54993ba to
5931571
Compare
eloycoto
approved these changes
Jun 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes THREESCALE-2755
See the JIRA epic for a more detailed description: THREESCALE-2752
This uses the new
3scale-limit-max-valueheader returned by apisonator: 3scale/apisonator#103