[config] add support to filter services by endpoint. #1022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidor
reviewed
Apr 25, 2019
davidor
reviewed
Apr 25, 2019
davidor
reviewed
Apr 25, 2019
davidor
reviewed
Apr 25, 2019
davidor
reviewed
Apr 25, 2019
mikz
reviewed
Apr 25, 2019
doc/parameters.md
Outdated
| ### `APICAST_SERVICES_FILTER` | ||
| **Value:** a regegular expression | ||
| **Default:**: .* | ||
| **Example:** *.example.com |
There was a problem hiding this comment.
Will it be possible to supply multiple patterns? I totally could see that there will be two wildcards in some cases.
There was a problem hiding this comment.
Hm. Based on the code it looks like this should be a regex, but from the example, it looks like a wildcard.
There was a problem hiding this comment.
should be clear now ;-)
There was a problem hiding this comment.
*.example.com is not valid PCRE no?
davidor
reviewed
Apr 25, 2019
davidor
reviewed
Apr 25, 2019
mikz
reviewed
Apr 25, 2019
eloycoto
force-pushed
the
THREESCALE-1524
branch
6 times, most recently
from
16e837e to
c06bb02
Compare
mayorova
reviewed
Apr 26, 2019
davidor
reviewed
Apr 26, 2019
davidor
reviewed
Apr 26, 2019
davidor
reviewed
Apr 26, 2019
davidor
reviewed
Apr 26, 2019
davidor
reviewed
Apr 26, 2019
eloycoto
force-pushed
the
THREESCALE-1524
branch
from
c06bb02 to
875a7d6
Compare
davidor
reviewed
Apr 26, 2019
davidor
reviewed
Apr 26, 2019
eloycoto
force-pushed
the
THREESCALE-1524
branch
from
875a7d6 to
2b42352
Compare
porueesq
reviewed
Apr 26, 2019
porueesq
reviewed
Apr 26, 2019
porueesq
suggested changes
Apr 26, 2019
davidor
reviewed
Apr 26, 2019
davidor
reviewed
Apr 26, 2019
davidor
reviewed
Apr 26, 2019
|
|
||
| it("combination with service list", function() | ||
| env.set('APICAST_SERVICES_FILTER_BY_URL', '^test.*') | ||
| assert.same(filter_services(mockservices, {"21"}), { |
There was a problem hiding this comment.
Would this test be clearer if the 2 variables were set at the beginning and we had a single assert?
davidor
reviewed
Apr 26, 2019
davidor
reviewed
Apr 26, 2019
davidor
reviewed
Apr 26, 2019
Migrated t/apicast-subset-of-services.t tests to the new testing Blackbox schema Signed-off-by: Eloy Coto <eloy.coto@gmail.com>
eloycoto
force-pushed
the
THREESCALE-1524
branch
3 times, most recently
from
c1a6267 to
01f8778
Compare
porueesq
approved these changes
Apr 26, 2019
eloycoto
force-pushed
the
THREESCALE-1524
branch
from
01f8778 to
1b85f11
Compare
mikz
reviewed
Apr 29, 2019
mikz
reviewed
Apr 29, 2019
davidor
reviewed
Apr 29, 2019
eloycoto
force-pushed
the
THREESCALE-1524
branch
2 times, most recently
from
e8b95b3 to
a3b9fdd
Compare
mikz
reviewed
Apr 29, 2019
| **Default:**: .* | ||
| **Example:** *.example.com | ||
|
|
||
| Used to filter the service configured in the 3scale API Manager, the filter |
There was a problem hiding this comment.
We probably should mention the filter is PCRE.
davidor
approved these changes
Apr 29, 2019
eloycoto
force-pushed
the
THREESCALE-1524
branch
from
a3b9fdd to
6a1e44b
Compare
This commit adds the option to filter services based on the endpoint. This commit expose a new config flag using the env variable `APICAST_SERVICES_FILTER_BY_URL`, services filter happens on `configuration.filter_services`. Signed-off-by: Eloy Coto <eloy.coto@gmail.com>
This test validates that the parameter `APICAST_SERVICE_FILTER_BY_URL` is working correctly across multiple services and the service discarding is working correctly. Signed-off-by: Eloy Coto <eloy.coto@gmail.com>
eloycoto
force-pushed
the
THREESCALE-1524
branch
from
6a1e44b to
6c7702b
Compare
|
|
?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the option to filter services based on the endpoint.
This commit expose a new config flag using the env variable
APICAST_SERVICES_FILTER, services filter happens onconfiguration.filter_services.Signed-off-by: Eloy Coto eloy.coto@gmail.com