-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify parameter names #207
Comments
This was referenced Jan 9, 2017
Closed
@mikz this would also be a valid issue for amp template right? |
Probably need a heads-up for any documentation changes that will be needed outside the repo due to this? |
Yes. That's another reason why it wasn't done yet. There is not clear proposal and it would require coordination.
Odesláno z iPhonu
24. 1. 2017 v 18:34, Andrew Mackenzie <notifications@github.com>:
… Probably need a heads-up for any documentation changes that will be needed outside the repo due to this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
mikz
added a commit
that referenced
this issue
Mar 15, 2017
* unify naming (closes #207) * remove unused options (closes https://issues.jboss.org/browse/THREESCALE-94)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Some parameters start with
THREESCALE_
and some withAPICAST_
and some with no prefix at all. Some don't match their name in the OpenShift template.Expected Result
All parameters in the OpenShift template should follow the same format. They don't have to necessarily be the same as the APIcast environment variable, because the prefix might be redundant.
Reported in #176
The text was updated successfully, but these errors were encountered: