Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify parameter names #207

Closed
mikz opened this issue Jan 9, 2017 · 4 comments · Fixed by #305
Closed

Unify parameter names #207

mikz opened this issue Jan 9, 2017 · 4 comments · Fixed by #305
Assignees

Comments

@mikz
Copy link
Contributor

mikz commented Jan 9, 2017

Some parameters start with THREESCALE_ and some with APICAST_ and some with no prefix at all. Some don't match their name in the OpenShift template.

Expected Result

All parameters in the OpenShift template should follow the same format. They don't have to necessarily be the same as the APIcast environment variable, because the prefix might be redundant.

Reported in #176

@thomasmaas
Copy link
Member

@mikz this would also be a valid issue for amp template right?

@mikz
Copy link
Contributor Author

mikz commented Jan 24, 2017 via email

@andrewdavidmackenzie
Copy link
Member

Probably need a heads-up for any documentation changes that will be needed outside the repo due to this?

@mikz
Copy link
Contributor Author

mikz commented Jan 24, 2017 via email

mikz added a commit that referenced this issue Mar 15, 2017
* unify naming (closes #207)
* remove unused options (closes https://issues.jboss.org/browse/THREESCALE-94)
@ghost ghost assigned mikz Mar 15, 2017
@ghost ghost added the B-current label Mar 15, 2017
@octobot octobot added the T-obux label Mar 15, 2017
@mikz mikz closed this as completed in #305 Mar 15, 2017
@ghost ghost removed the B-current label Mar 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants