Skip to content

Commit

Permalink
Merge pull request #275 from 3scale/doc-management-debugging
Browse files Browse the repository at this point in the history
[doc] management api is for debugging only
  • Loading branch information
mikz authored Mar 2, 2017
2 parents c60999c + 2a470cb commit 0649c36
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 5 deletions.
7 changes: 5 additions & 2 deletions Dangerfile
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ warn("PR is classed as Work in Progress") if github.pr_title.include? "[WIP]"
# Warn when there is a big PR
warn("Big PR") if git.lines_of_code > 500

has_app_changes = git.modified_files.grep(%{apicast/})
has_app_changes = git.modified_files.grep(%{apicast/}).any?
markdown_files = git.modified_files.grep(/\.md$/)

if !git.modified_files.include?("CHANGELOG.md") && has_app_changes
Expand All @@ -20,5 +20,8 @@ ENV['LANG'] = 'en_US.utf8'
prose.lint_files markdown_files - %w(CHANGELOG.md)

# Look for spelling issues
prose.ignored_words = %w(s2i openresty APIcast nameservers resty-resolver nginx Redis OAuth ENV backend 3scale OpenShift Default Lua)
prose.ignored_words = %w(
s2i openresty APIcast nameservers resty-resolver nginx Redis OAuth ENV backend 3scale OpenShift Default Lua
hostname LRU cosocket TODO lua-resty-lrucache
)
prose.check_spelling markdown_files - %w(CHANGELOG.md)
6 changes: 3 additions & 3 deletions doc/configuration.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
# Configuration and its persistence

Gateway needs configuation in order to work. It needs it to determine service configuration, hostname, etc.
Gateway needs configuration in order to work. It needs it to determine service configuration, hostname, etc.

Gateway can load the configuration from file, API or write it through management API.
Gateway can load the configuration from file, API or write it through management API (for debugging purposes).

## Configuration loading

Expand Down Expand Up @@ -42,4 +42,4 @@ Can survive restart. Still needs some other method to act as cache.

3scale hosts thousands of gateways for its customers and needs a reasonable way to share resources between them. Multi-tenant deployment of this proxy is the preferred way.

TODO: figure out how to store/load the configuration in multi-tenant way
TODO: figure out how to store/load the configuration in multi-tenant way
2 changes: 2 additions & 0 deletions doc/management-api.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

Management API is a simple API that allows updating or retrieving the configuration currently used by the gateway. The API is available on port `8090`.

This is mean to be used for **debugging purposes only**. Offers no authentication or synchronization between several instances.

Available endpoints:

- `GET /config`
Expand Down

0 comments on commit 0649c36

Please sign in to comment.