Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

product method metrics mappingrules endpoints #26

Merged
merged 3 commits into from
Jun 6, 2020
Merged

product method metrics mappingrules endpoints #26

merged 3 commits into from
Jun 6, 2020

Conversation

eguzki
Copy link
Member

@eguzki eguzki commented Jun 5, 2020 •
edited
Loading

  • Product Method endpoints
  • Product Metric endpoints
  • Product MappingRule endpoints

@eguzki eguzki changed the title product method endpoints product method metrics mappingrules endpoints Jun 5, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jun 5, 2020 •
edited
Loading

Codecov Report

Merging #26 into master will increase coverage by 4.76%.
The diff coverage is 69.69%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #26      +/-   ##
==========================================
+ Coverage   38.26%   43.03%   +4.76%     
==========================================
  Files          14       14              
  Lines        1108     1306     +198     
==========================================
+ Hits          424      562     +138     
- Misses        603      633      +30     
- Partials       81      111      +30
Impacted Files Coverage Δ
client/product.go 54.76% <69.69%> (+54.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d87f43d...b3ee145. Read the comment docs.

@eguzki eguzki marked this pull request as ready for review June 5, 2020 16:11
@eguzki eguzki requested a review from philipgough June 5, 2020 16:11
@eguzki eguzki merged commit 94aa3ab into master Jun 6, 2020
@eguzki eguzki deleted the product-metrics-methods-mappingrules branch June 6, 2020 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipgough philipgough philipgough approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eguzki @codecov-commenter @philipgough