Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix json response parsing when not needed #25

Merged
merged 1 commit into from
May 22, 2020

Conversation

eguzki
Copy link
Member

@eguzki eguzki commented May 19, 2020

If the user does not want to parse response, let it be.

@eguzki eguzki requested a review from philipgough May 19, 2020 16:00
@codecov-commenter
Copy link

Codecov Report

Merging #25 into master will increase coverage by 0.19%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #25      +/-   ##
==========================================
+ Coverage   24.93%   25.12%   +0.19%     
==========================================
  Files          13       13              
  Lines         778      780       +2     
==========================================
+ Hits          194      196       +2     
  Misses        553      553              
  Partials       31       31              
Impacted Files Coverage Δ
client/client.go 68.80% <100.00%> (+0.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2e3a7f...15b5539. Read the comment docs.

@eguzki eguzki merged commit ed2eb10 into master May 22, 2020
@eguzki eguzki deleted the fix-json-response-handling branch May 22, 2020 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants