feat/resource-reconcilers #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3scale-robot
added
kind/feature
3scale-robot
added
size/M
slopezz
reviewed
Oct 7, 2022
|
|
||
| var _ basereconciler.Resource = ExternalSecretTemplate{} | ||
|
|
||
| // PodDisruptionBudget specifies a PodDisruptionBudget resource |
slopezz
reviewed
Oct 7, 2022
|
/lgtm |
|
LGTM label has been added. Git tree hash: b895e5041d821de2e11f86e05a5885a2df8e6a95
|
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: roivaz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3scale-robot
added
the
approved
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds custom reconcilers for PodMonitor, ExternalSecret, GrafanaDashboard and ConfigMap resources to stop using operator-utils and have more control. Especially important is the reduction in the amount of logs that were generated by the periodic reconcile loops of ExternalSecret resources.
/kind feature
/priority important-longterm
/assign