Bump required CMake version and clean up a little #889
+12
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also allows up to set the max version to current as we're not using any removed features.
Now we can use TARGET_FILE_BASE_NAME
We don't use it any more. (If we need it again we can just bump the min CMake ver to 3.16)
Daft-Freak
force-pushed
the
cmake-ver-bump
branch
from
0db3564 to
44459fa
Compare
|
On the off chance it crops up here: I had a heck of a time recently on macOS trying to get I had to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bit of a continuation of #878, the first patch makes it so we aren't using a "removed" feature.