Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split examples #803

Closed
wants to merge 11 commits into from
Closed

Split examples #803

wants to merge 11 commits into from

Conversation

Daft-Freak
Copy link
Collaborator

#744, but moving everything. More discussion over there. WIP.

@Daft-Freak
Copy link
Collaborator Author

There's certainly a lot of duplication in the docs... and a lot of the phrase "Set up the 32Blit Makefile from the root of the repository", I feel like that needs rewording somehow.

@Daft-Freak
Copy link
Collaborator Author

Will squash the hardware-test undelete into the delete to not mess up history. (Unless we don't keep them here).

Could move the launcher next to those too... 🤔

@Gadgetoid
Copy link
Contributor

I really need to stop crashing into bed in the evenings and get onto 32blit/32blit-examples#1 😬

@Daft-Freak
Copy link
Collaborator Author

Ah, this is being held up by documentation isn't it?

There's nothing interesting in the SDK (except maybe a non-functional launcher)
They still don't have their own and the examples are about to move
They've moved out to 32blit/32blit-examples
At least the location of the examples is right now
All they would include is a semi-functional launcher
Just the hardware tests
@Gadgetoid
Copy link
Contributor

This is being held up by documentation and that's entirely my fault. It's been gnawing at my brain all this time, but I haven't had an opportunity to sort it. 😬

@Daft-Freak
Copy link
Collaborator Author

Well, it's not like I didn't completely forget about this myself...

(Too busy hacking on emulators apparently.)

@Gadgetoid
Copy link
Contributor

Not me finding examples in the SDK very, very useful again... 😆

@Daft-Freak
Copy link
Collaborator Author

Anything can be "in" the SDK with enough add_subdirectorys hacked in. 😆

(I may have a few extras added most of the time)

@Daft-Freak
Copy link
Collaborator Author

🤔

if(EXISTS ${CMAKE_CURRENT_LIST_DIR}/examples/CMakeLists.txt)
    add_subdirectory(examples)
endif()
  1. clone 32blit-examples to examples
  2. Pretend nothing changed

@Gadgetoid
Copy link
Contributor

Wait haven't we just reinvented git submodules? 🤔

@Daft-Freak
Copy link
Collaborator Author

Daft-Freak commented Jun 17, 2024

Uh kinda, but specifying a specific commit of the examples doesn't seem useful.

(Mostly thinking of a way to make this change slightly less huge)

@Gadgetoid
Copy link
Contributor

Yeah that's a good point, and was nagging away at the back of my mind 😆

@Daft-Freak
Copy link
Collaborator Author

master...Daft-Freak:32blit-beta:split-examples-2 + 32blit/32blit-examples#3 seems to work. Didn't even delete the .sln, it just explodes if the examples aren't there...

@Daft-Freak Daft-Freak mentioned this pull request Jun 24, 2024
@Daft-Freak Daft-Freak closed this Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants