Feature/playwright migration #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cmfive-boilerplate into feature/PlaywrightMigration
…back add readme and gitignore
…cmfive-boilerplate into feature/PlaywrightMigration
…cmfive-boilerplate into feature/PlaywrightMigration
…ght test job doesn't fail whenever a module test fails
…cmfive-boilerplate into feature/PlaywrightMigration
.gitignore
Outdated
| @@ -8,8 +8,6 @@ | |||
| /storage/session | |||
| /log | |||
|
|
|||
| .phpunit.result.cache | |||
There was a problem hiding this comment.
Why do we version this now?
There was a problem hiding this comment.
We shouldn't not sure why this was removed
test/playwright/README.md
Outdated
| @@ -0,0 +1,61 @@ | |||
| # Get Cmfive Working | |||
|
|
|||
| - Use this codespace: https://github.com/2pisoftware/codespace_dev_box/tree/BoilerplateCore_Modules_Tests_Debug | |||
There was a problem hiding this comment.
This now outdated? Also, per chatter elsewhere around doc's, this is not a cmfive public repo/reference?
There was a problem hiding this comment.
will remove the "Get Cmfive Working" part, was for Dane to follow while trying to get the newer codespace to be playwright friendly
DerekCrannaford
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Merging Playwright setup into develop