Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Revamp info on how to add a new hub #498

Merged
merged 7 commits into from
Aug 2, 2021

Conversation

yuvipanda
Copy link
Member

Is also a jumping off point for other things that need
to be better documented.

Copy link
Member

@GeorgianaElena GeorgianaElena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just love it! 🎉

I noticed that opening up a new GitHub issue is not in the steps anymore. Not sure if this was the intention, but I think we should keep it, since it helps us organize :D Maybe add a note abut it at the end to instruct ticking the right boxes after the hub was added, or open a new issue if one wasn't opened already?

Copy link
Member

@sgibson91 sgibson91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! Agree with everyone else's comments so far

Copy link
Member

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really great and very helpful for people like me who have not deployed a ton of hubs :-). I added in a few comments about extra information / context we might want to add. Happy to iterate on this a bit more!

Note that this may also close 2i2c-org/team-compass#128

docs/howto/operate/add-hub.md Show resolved Hide resolved
@@ -1,8 +1,67 @@
# Add a new hub

Adding a new hub requires that we do three things:
## Step 1: Decide where the hub will live
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Step 1: Decide where the hub will live
## Step 0: Open a GitHub issue
In order to track progress on deploying the new hub, [open a GitHub issue in the `support/` repository](https://github.com/2i2c-org/support/issues/new/choose).
Make sure to choose the `new-hub` issue template.
## Step 1: Decide where the hub will live

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

per @GeorgianaElena's comment, I've created an empty support/ repo that we can start to modify to suit our support processes. For creating a hub, how about the text above + we create an issue template for creating a new hub that has a checklist corresponding to each of the steps here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I incorporated this, but pointing to pilot-hubs still. 2i2c-org/team-compass#151 talks about the support/ repository.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that is OK for now, @choldgraf?

docs/howto/operate/add-hub.md Show resolved Hide resolved
docs/howto/operate/add-hub.md Outdated Show resolved Hide resolved

## Step 4: Decide the authentication provider to be used

In consultation with the users, decide
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On this page, perhaps we should define a Community Champion role for a hub (or maybe we should re-name this "user representative"?) and then suggest that we ask this person questions throughout the process, rather than to use a generic "user" identity like here? I'd like us to move away from the possibility that multiple users on a hub might be needed to answer questions.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like us to move away from the possibility that multiple users on a hub might be needed to answer questions.

💯

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@choldgraf, until we have the Community champion role well defined, I think this is OK for now. Let us know if you disagree.

docs/howto/operate/add-hub.md Show resolved Hide resolved
docs/howto/operate/add-hub.md Show resolved Hide resolved
docs/howto/operate/add-hub.md Show resolved Hide resolved
docs/howto/operate/add-hub.md Show resolved Hide resolved
docs/howto/operate/add-hub.md Outdated Show resolved Hide resolved
yuvipanda and others added 5 commits July 12, 2021 18:26
Is also a jumping off point for other things that need
to be better documented.
Co-authored-by: Chris Holdgraf <choldgraf@gmail.com>
Copy link
Member Author

@yuvipanda yuvipanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I've addressed everything, by either amending the docs or opening new issues :)

docs/howto/operate/add-hub.md Show resolved Hide resolved
docs/howto/operate/add-hub.md Outdated Show resolved Hide resolved
docs/howto/operate/add-hub.md Show resolved Hide resolved
docs/howto/operate/add-hub.md Outdated Show resolved Hide resolved
docs/howto/operate/add-hub.md Outdated Show resolved Hide resolved
docs/howto/operate/add-hub.md Show resolved Hide resolved
docs/howto/operate/add-hub.md Show resolved Hide resolved
docs/howto/operate/add-hub.md Show resolved Hide resolved
docs/howto/operate/add-hub.md Show resolved Hide resolved
@@ -1,8 +1,67 @@
# Add a new hub

Adding a new hub requires that we do three things:
## Step 1: Decide where the hub will live
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I incorporated this, but pointing to pilot-hubs still. 2i2c-org/team-compass#151 talks about the support/ repository.

Copy link
Contributor

@damianavila damianavila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the remaining things could be changed in a follow-up PR. Approving...

Copy link
Member

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm playing a game kind of like charades with my french family. But it's all in french and i have no idea what anybody is saying, so I'm approving this PR 😅

@yuvipanda yuvipanda merged commit f574c22 into 2i2c-org:master Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants