Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Don't merge until Jan 9] Promote UToronto staging images to prod #3582

Merged
merged 1 commit into from
Jan 9, 2024
Merged

[Don't merge until Jan 9] Promote UToronto staging images to prod #3582

merged 1 commit into from
Jan 9, 2024

Conversation

yuvipanda
Copy link
Member

Ref #2729

@yuvipanda
Copy link
Member Author

UToronto folks have tested this and found it ok per https://2i2c.freshdesk.com/a/tickets/952

@yuvipanda yuvipanda requested a review from a team as a code owner January 6, 2024 01:04
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 6, 2024

Merging this PR will trigger the following deployment actions.

Support and Staging deployments

Cloud Provider Cluster Name Upgrade Support? Reason for Support Redeploy Upgrade Staging? Reason for Staging Redeploy
kubeconfig utoronto No Yes Following helm chart values files were modified: r-staging.values.yaml, r-common.values.yaml

Production deployments

Cloud Provider Cluster Name Hub Name Reason for Redeploy
kubeconfig utoronto prod Following helm chart values files were modified: default-common.values.yaml
kubeconfig utoronto r-prod Following helm chart values files were modified: r-common.values.yaml

yuvipanda added a commit to yuvipanda/pilot-hubs that referenced this pull request Jan 8, 2024
@yuvipanda
Re-add singleuser image tag
0501fe1 
Should be removed as part of
2i2c-org#3582 instead
@yuvipanda yuvipanda mentioned this pull request Jan 8, 2024
Closed
@yuvipanda yuvipanda merged commit 91db123 into 2i2c-org:master Jan 9, 2024
9 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2024

🎉🎉🎉🎉

Monitor the deployment of the hubs here 👉 https://github.com/2i2c-org/infrastructure/actions/runs/7464985015

yuvipanda added a commit to yuvipanda/pilot-hubs that referenced this pull request Jan 9, 2024
@yuvipanda
utoronto: Don't force usage of notebookapp
c13775b 
2i2c-org#3582 has
been merged, so we can stop forcing NotebookApp in prod.

Without this, JupyterLab actually fails to launch,
fixed upstream in jupyter-server/jupyter_server#1384

Ref 2i2c-org#2729
@yuvipanda yuvipanda mentioned this pull request Jan 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@consideRatio consideRatio consideRatio approved these changes

Assignees

@yuvipanda yuvipanda

Labels
None yet
Projects
No open projects
Sprint Board
Status: Done 🎉
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuvipanda @consideRatio