Deploy jupyterhub-configurator #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simple deployment of github.com/yuvipanda/jupyterhub-configurator. - Built into the hub image, as that's the easiest - we need the package there anyway, to use the mixin. Will probably move to its own container as a sidecar at some point soon. - Seprate service named configurator for the proxy to be able to find it, even though it's in the same container as the hub! We can't expose more ports from the hub service, so the proxy can't actually reach port 10101 on the hub container. We need a new service, plus appropriate networlpolicy rules for this. This should be made simpler. - Use configurator mixin to bring let the spawner take in dynamic configuration. This means spawns *will fail* if the configurator fails, and that's ok. Explicit decision to try make this work well. - Chartpress to build and push the image.
Don't want to rebuild this for each project we maintain.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple deployment of https://github.com/yuvipanda/jupyterhub-configurator.
the package there anyway, to use the mixin.
Will probably move to its own container as a sidecar at
some point soon.
find it, even though it's in the same container as the hub!
We can't expose more ports from the hub service, so the proxy
can't actually reach port 10101 on the hub container. We need
a new service, plus appropriate networlpolicy rules for this.
This should be made simpler.
configuration. This means spawns will fail if the configurator
fails, and that's ok. Explicit decision to try make this work
well.
don't want to push a copy of the image to each project. Hub images
are pulled infrequently enough for this to be ok.
Ref #312