Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove contact element in APIv4 #8147

Merged
merged 1 commit into from
Aug 3, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions scripts/APIv4.js
Original file line number Diff line number Diff line change
Expand Up @@ -59,12 +59,6 @@ const processEntries = async (files) => {
const data = await readJSONFile(file);
const entry = data[Object.keys(data)[0]];

// Rename contact.twitter to contact.x if it exists
if (entry.contact && entry.contact.twitter) {
entry.contact.x = entry.contact.twitter;
delete entry.contact.twitter;
}

// Add the main domain entry
entries[entry.domain] = entry;

Expand Down Expand Up @@ -93,7 +87,6 @@ const generateApi = async (entries) => {
Object.entries(entries).map(async ([domain, entry]) => {
const apiEntry = {
methods: entry["tfa"],
contact: entry.contact,
"custom-software": entry["custom-software"],
"custom-hardware": entry["custom-hardware"],
documentation: entry.documentation,
Expand Down
27 changes: 0 additions & 27 deletions tests/schemas/APIv4.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,33 +23,6 @@
]
}
},
"contact": {
"type": "object",
"description": "Contact information for the service.",
"properties": {
"email": {
"type": "string",
"format": "email"
},
"facebook": {
"type": "string",
"minLength": 1
},
"x": {
"type": "string",
"pattern": "^(\\w){1,15}$"
},
"form": {
"type": "string",
"format": "uri"
},
"language": {
"type": "string",
"pattern": "^[a-z]{2}$"
}
},
"additionalProperties": false
},
"custom-software": {
"type": "array",
"description": "Custom software 2FA solutions used by the service.",
Expand Down