Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Rate Limit Hanling #20

Closed
alexphelps opened this issue Feb 6, 2024 · 0 comments · Fixed by #21
Closed

Improve Rate Limit Hanling #20

alexphelps opened this issue Feb 6, 2024 · 0 comments · Fixed by #21
Assignees
@reloadsweety

Comments

@alexphelps
Copy link
Member

Issue

Occasionally get rate limit errors with ntk push which stops the process entirely without a way to slow down and continue.

Example

Uploading 175 files to theme id 350
2024-02-06 05:10:17 INFO Uploading partials/recommended_products.html file to theme id #350 failed. -> Request was throttled. Expected available in 1 second.

Expected

Should automatically handle rate limit errors or slow down requests just enough to not hit the error.
@reloadsweety reloadsweety self-assigned this Mar 22, 2024
reloadsweety pushed a commit that referenced this issue Mar 22, 2024
THEME-KIT #20 | update test
490971b
reloadsweety pushed a commit that referenced this issue Mar 22, 2024
THEME-KIT #20 | add time sleep when push template
295e4ea
reloadsweety pushed a commit that referenced this issue Mar 22, 2024
THEME-KIT #20 | fix test
0bcc3c1
reloadsweety pushed a commit that referenced this issue Mar 22, 2024
THEME-KIT #20 | fix flake8
326aca3
@reloadsweety reloadsweety linked a pull request Mar 22, 2024 that will close this issue
20 improve rate limit handling #21
Merged
reloadsweety pushed a commit that referenced this issue Mar 22, 2024
THEME-KIT #20 | add retry when rate limit
35d8f38
reloadsweety pushed a commit that referenced this issue Mar 22, 2024
THEME-KIT #20 | change version
a50692f
reloadsweety pushed a commit that referenced this issue Mar 22, 2024
THEME-KIT #20 | update test
6f7f5df
reloadsweety pushed a commit that referenced this issue Mar 22, 2024
THEME-KIT #20 | update test
52c6be0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reloadsweety reloadsweety

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

20 improve rate limit handling 29next/theme-kit
2 participants
@alexphelps @reloadsweety