PISTON-1123: Fixes voicemail forward confirmation. #6646
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 16, 2020 18:42
The `cf_voicemail:forward_message/6` function has been refactored to consistently execute the forwarding operation as an asynchronous task and to play the confirmation of the operation synchronously. The previous flow of control was inconsistent, depending on configuration. In some circumstances, the forwarding operation was performed asynchronously, but this resulted in no audible confirmation. In other circumstances, forwarding was performed synchronously.
jamesaimonetti
pushed a commit
that referenced
this pull request
Oct 19, 2020
The `cf_voicemail:forward_message/6` function has been refactored to consistently execute the forwarding operation as an asynchronous task and to play the confirmation of the operation synchronously. The previous flow of control was inconsistent, depending on configuration. In some circumstances, the forwarding operation was performed asynchronously, but this resulted in no audible confirmation. In other circumstances, forwarding was performed synchronously.
|
Merged, thanks! |
tetrachromium
deleted the
Voxter-PISTON-1123-voicemail-forward-confirmation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
cf_voicemail:forward_message/6function has been refactored to consistently execute the forwarding operation as an asynchronous task and to play the confirmation of the operation synchronously. The previous flow of control was inconsistent, depending on configuration. In some circumstances, the forwarding operation was performed asynchronously, but this resulted in no audible confirmation. In other circumstances, forwarding was performed synchronously.