Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.3] PISTON-1141: VM setup/configurability fixes #6642

Conversation

danielfinke
Copy link
Member

  • vmboxes that are not set up should still offer setup when in announcement-only mode
  • in announcement-only mode, if configurability is disabled, go straight to mailbox
    • if configurability is enabled, go to config menu. The expectation is the primary action they will want is to disable announcement-only mode. They can get to mailbox with '0'

@danielfinke danielfinke changed the title PISTON-1141: VM setup/configurability fixes (pull request #1058) [4.3] PISTON-1141: VM setup/configurability fixes (pull request #1058) Oct 15, 2020
@danielfinke danielfinke force-pushed the pr-PISTON-1141-vm-setup-configurability-fixes branch from 72738d8 to bce7144 Compare October 15, 2020 23:49
@danielfinke danielfinke changed the title [4.3] PISTON-1141: VM setup/configurability fixes (pull request #1058) [4.3] PISTON-1141: VM setup/configurability fixes Oct 15, 2020
danielfinke added a commit to voxter/kazoo that referenced this pull request Oct 15, 2020
- vmboxes that are not set up should still offer setup when in
  announcement-only mode
- in announcement-only mode, if configurability is disabled, go straight
  to mailbox
  - if configurability is enabled, go to config menu. The expectation is
    the primary action they will want is to disable announcement-only
    mode. They can get to mailbox with '0'
@danielfinke danielfinke force-pushed the pr-PISTON-1141-vm-setup-configurability-fixes branch from bce7144 to 09fbab2 Compare October 15, 2020 23:50
- vmboxes that are not set up should still offer setup when in
  announcement-only mode
- in announcement-only mode, if configurability is disabled, go straight
  to mailbox
  - if configurability is enabled, go to config menu. The expectation is
    the primary action they will want is to disable announcement-only
    mode. They can get to mailbox with '0'
@danielfinke danielfinke force-pushed the pr-PISTON-1141-vm-setup-configurability-fixes branch from 09fbab2 to 843f3bc Compare October 15, 2020 23:50
jamesaimonetti pushed a commit that referenced this pull request Oct 19, 2020
- vmboxes that are not set up should still offer setup when in
  announcement-only mode
- in announcement-only mode, if configurability is disabled, go straight
  to mailbox
  - if configurability is enabled, go to config menu. The expectation is
    the primary action they will want is to disable announcement-only
    mode. They can get to mailbox with '0'
@jamesaimonetti
Copy link
Member

Merged

@danielfinke danielfinke deleted the pr-PISTON-1141-vm-setup-configurability-fixes branch October 21, 2020 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants