PISTON-1137: Fixes inaccurate stack trace. #6638
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an exception is caught within the `kvm_message:prepend_and_notify/5` function, the correct stack trace was potentially overwritten by an exception occuring within the `kvm_message:remove_malform_vm/2` function. The stack trace is now captured before calling that function.
jamesaimonetti
pushed a commit
that referenced
this pull request
Oct 12, 2020
If an exception is caught within the `kvm_message:prepend_and_notify/5` function, the correct stack trace was potentially overwritten by an exception occuring within the `kvm_message:remove_malform_vm/2` function. The stack trace is now captured before calling that function.
|
Merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an exception is caught within the
kvm_message:prepend_and_notify/5function, the correct stack trace was potentially overwritten by an exception occuring within thekvm_message:remove_malform_vm/2function. The stack trace is now captured before calling that function.