[4.3] acdc - PISTON-1112: fix validation of agent pause timeout/time-limit #6617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
danielfinke
commented
Aug 7, 2020
danielfinke
commented
- schema validates system_config.acdc default_agent_pause_timeout for non-negative integers or the "infinity" special string
- refactored out ?DEFAULT_AGENT_PAUSE_TIMEOUT into shared header
- fixed acdc_maintenance expecting integer, despite possibility of <<"infinity">> value
- moved Time-Limit validation in kapi_acdc_agent into PAUSE_* macros rather than AGENT_*
- schema validates system_config.acdc default_agent_pause_timeout for non-negative integers or the "infinity" special string - refactored out ?DEFAULT_AGENT_PAUSE_TIMEOUT into shared header - fixed acdc_maintenance expecting integer, despite possibility of <<"infinity">> value - moved Time-Limit validation in kapi_acdc_agent into PAUSE_* macros rather than AGENT_*
- the rule *.log* in the root gitignore ignored these files :/ - remove Time-Limit from these schemas
- retain support for using default by omitting `"timeout"` from pause API reqs
jamesaimonetti
pushed a commit
that referenced
this pull request
Sep 22, 2020
- schema validates system_config.acdc default_agent_pause_timeout for non-negative integers or the "infinity" special string - refactored out ?DEFAULT_AGENT_PAUSE_TIMEOUT into shared header - fixed acdc_maintenance expecting integer, despite possibility of <<"infinity">> value - moved Time-Limit validation in kapi_acdc_agent into PAUSE_* macros rather than AGENT_* PISTON-1119: add incorrectly gitignored kapi.acdc_agent schemas - the rule *.log* in the root gitignore ignored these files :/ - remove Time-Limit from these schemas PISTON-1122: Time-Limit should be optional in agent.pause AMQP events - retain support for using default by omitting `"timeout"` from pause API reqs
|
merged |
danielfinke
deleted the
pr-PISTON-1112-fix-validation-of-agent-pause-timeout
branch
kageds
pushed a commit
to kageds/kazoo
that referenced
this pull request
Sep 24, 2020
…#6617) - schema validates system_config.acdc default_agent_pause_timeout for non-negative integers or the "infinity" special string - refactored out ?DEFAULT_AGENT_PAUSE_TIMEOUT into shared header - fixed acdc_maintenance expecting integer, despite possibility of <<"infinity">> value - moved Time-Limit validation in kapi_acdc_agent into PAUSE_* macros rather than AGENT_* PISTON-1119: add incorrectly gitignored kapi.acdc_agent schemas - the rule *.log* in the root gitignore ignored these files :/ - remove Time-Limit from these schemas PISTON-1122: Time-Limit should be optional in agent.pause AMQP events - retain support for using default by omitting `"timeout"` from pause API reqs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.