[4.3] Upstream 4.3 telnyx carrier api issues #6615
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
searching for toll-free numbers. When searching for toll-free numbers the api request sent to telnyx was incorrect resulting in a poor number search response.
This will fix a bug where the quantity of numbers requested during a search was always overwritten to the max search size that defaults to 500 resulting in longer query times.
…hing for numbers with the telnyx module. The option is now passed to telnyx as part of the api request as opposed to filtering the response in kazoo.
broken as a result of the changes to the telnyx requests.
jamesaimonetti
requested changes
Sep 24, 2020
bradfordben
force-pushed
the
upstream-4.3-telnyx-carrier-api-issues
branch
from
b203833 to
48f7c80
Compare
bradfordben
force-pushed
the
upstream-4.3-telnyx-carrier-api-issues
branch
from
48f7c80 to
95fc21c
Compare
magic numbers to new definitions
jamesaimonetti
pushed a commit
that referenced
this pull request
Oct 2, 2020
Fixes to the Telnyx carrier module The best effort configuration setting did not work, My guess is that this was written and then telnyx changed the api response and the response to no longer included the flag “any_best_effort” so the old code would never filter the best effort out. This improvement will now pass the best effort flag to telnyx and remove the need to filter the response. Requests for TF numbers was failing as the request built and passed to Telnyx was incorrect. It passed the TF NAP as `prefix` in the body and it should be `nap` as there api doc states. I have also added the option to filer TF numbers by NXX. Also found that the crossbar quantity option was always overwritten to 500 so every time you requested 15 numbers through CB it requested 500 from telnyx resulting in longer query times. The fix was to only set the default values if they were not set.
|
Merged |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes to the Telnyx carrier module
The best effort configuration setting did not work, My guess is that this was written and then telnyx changed the api response and the response to no longer included the flag “any_best_effort” so the old code would never filter the best effort out. This improvement will now pass the best effort flag to telnyx and remove the need to filter the response.
Requests for TF numbers was failing as the request built and passed to Telnyx was incorrect. It passed the TF NAP as
prefixin the body and it should benapas there api doc states. I have also added the option to filer TF numbers by NXX.Also found that the crossbar quantity option was always overwritten to 500 so every time you requested 15 numbers through CB it requested 500 from telnyx resulting in longer query times. The fix was to only set the default values if they were not set.
Kazoo5 PR https://github.com/2600hz/kazoo-core/pull/48