SUPP-8: read exisiting account document to get tree when importing enabled field #6614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When trying to disable an account via the Account Manager app, the account is not disabled. This bug was introduce when account creation/deletion was moved to core. Before that move, we properly load and merge the request document with doc from database so we had the `pvt_tree` field when we were checking ig the requestor is in account's tree. But this got moved into after validation and in `post/1,2` function and so we don't set enabled anymore.
icehess
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to disable an account via the Account Manager app, the account is not disabled.
This bug was introduce when account creation/deletion was moved to core.
Before that move, we properly load and merge the request document with doc from database
so we had the
pvt_treefield when we were checking ig the requestor is inaccount's tree.
But this got moved into after validation and in
post/1,2function and so wedon't set enabled anymore.