[4.3] Improve handling of slow websocket clients #6606
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a websocket client is having trouble reading messages off its
socket, backpressure will cause the mailbox of the
blackhole_socket_handler to start to fill up with {send_data, _}
tuples from blackhole_data_emitter. This is due to the sending of data
being stuck in prim_inet:send/3.
We add two mechnisms to try to avoid the server being harshly impacted
by slow clients:
the socket in the event of slow sends
blackhole_data_emitter before sending the {send_data, _} tuple, opting
to shed the load while waiting.