[4.3] - DUPT-193: Make conference websocket events more granular #6603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 30, 2020 11:07
- create telemetry consensus function - filter telemetry node_info from status
- Restore legacy binding logic as legacy binding strings were getting rewritten
This reverts commit fa06ab1.
lazedo
reviewed
Jul 7, 2020
Comment on lines
97
to
98
| Subscribed = [?ACCOUNT_BINDING(AccountId, ConferenceId, CallId)], | ||
| Listeners = [{'amqp', 'conference', event_binding_options(AccountId, ConferenceId, CallId)}], |
There was a problem hiding this comment.
Suggested change
| Subscribed = [?ACCOUNT_BINDING(AccountId, ConferenceId, CallId)], | |
| Listeners = [{'amqp', 'conference', event_binding_options(AccountId, ConferenceId, CallId)}], | |
| Subscribed = [?ACCOUNT_BINDING(AccountId, ConferenceId, CallId, ?ALL)], | |
| Listeners = [{'amqp', 'conference', event_binding_options(AccountId, ConferenceId, CallId, ?ALL)}], |
Comment on lines
128
to
138
| -spec event_binding_options(kz_term:ne_binary(), kz_term:ne_binary(), kz_term:ne_binary()) -> kz_term:proplist(). | ||
| event_binding_options(AccountId, ConferenceId, CallId) -> | ||
| [{'restrict_to', [{'event', [{'account_id', AccountId} | ||
| ,{'conference_id', ConferenceId} | ||
| ,{'call_id', CallId} | ||
| ] | ||
| }] | ||
| } | ||
| ,'federate' | ||
| ]. | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR Addresses a bug where the newly introduced granular subscriptions were passing the legacy binding thru and rewriting into the newer binding string.
Example:
was rewriting to
conference.event.b05d601a69718090248aec40ee8e049d.*.*