[4.3] PISTON-1088: more DRY Makefile dialyze targets #6597
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielfinke
commented
Jun 29, 2020
| @@ -10,7 +10,6 @@ | |||
|
|
|||
| main([]) -> | |||
| print_help(); | |||
| main([_KazooPLT]) -> 'ok'; | |||
There was a problem hiding this comment.
This clause was previously used to handle when no files were passed
| @@ -38,8 +37,7 @@ print_help() -> | |||
| getopt:usage(option_spec_list(), "ERL_LIBS=deps/:core/:applications/ " ++ Script ++ " .kazoo.plt [args] [file.beam | path/ebin/ ...]"), | |||
| halt(1). | |||
|
|
|||
| handle(_KazooPLT, _Options, []) -> | |||
| print_help(); | |||
| handle(_KazooPLT, _Options, []) -> 'ok'; | |||
There was a problem hiding this comment.
But this clause is needed to handle when no files were passed AND there was a flag such as --bulk or --hard passed. And it will handle the L13 clause as well.
- also make the output of check-dialyzer.escript consistently "nothing" whether using --bulk, --hard, or no flags at all
danielfinke
force-pushed
the
pr-PISTON-1088-more-dry-makefile-dialyze-targets
branch
from
ae9e981 to
1f9abb2
Compare
danielfinke
changed the title
jamesaimonetti
pushed a commit
that referenced
this pull request
Jun 29, 2020
- also make the output of check-dialyzer.escript consistently "nothing" whether using --bulk, --hard, or no flags at all
|
Merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
whether using --bulk, --hard, or no flags at all