[4.3] HELP-14771: Add stepswitch.min_shortdial_destination parameter #6552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesaimonetti
requested changes
May 29, 2020
jamesaimonetti
changed the title
harenson
changed the title
jamesaimonetti
requested changes
Jun 4, 2020
jamesaimonetti
requested changes
Jun 9, 2020
Allows for shortdial correction to only be applied if the destination is of at least a certain length. And also refactor short-dial correction code in order to be able to add unit tests for that functionality.
jamesaimonetti
force-pushed
the
help-14771
branch
from
0b92703 to
d3ad514
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And also refactor short-dial correction code in order to be able to add
unit tests for that functionality per @jamesaimonetti request.
Master PRs: