[4.3] KZOO-57: calculate presence id for route requests #6405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesaimonetti
force-pushed
the
KZOO-57-4.3
branch
from
7fc00f1 to
6ca8021
Compare
When a device registers, the calculated presence_id is cached and passed along on subsequent INVITEs. If a user hotdesks into the device, the cached presence_id (likely the SIP username of the device) will continue to be used on call events related to that device. This causes issues with applications (like Qubicle) that track a user's calls based on the user's presence_id being present on dialog update events (confirmed and terminated). Instead, provide a uniform way to calculate a device's presence_id and use it for setting CCVs on the route response in callflow and in registrar for authn responses.
jamesaimonetti
force-pushed
the
KZOO-57-4.3
branch
from
608758d to
3a55c89
Compare
lazedo
approved these changes
Mar 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a device registers, the calculated presence_id is cached and
passed along on subsequent INVITEs. If a user hotdesks into the
device, the cached presence_id (likely the SIP username of the device)
will continue to be used on call events related to that device.
This causes issues with applications (like Qubicle) that track a
user's calls based on the user's presence_id being present on dialog
update events (confirmed and terminated).
Instead, provide a uniform way to calculate a device's presence_id and
use it for setting CCVs on the route response in callflow and in
registrar for authn responses.