Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.3] KZOO-56: handle conflict when moving faxes to MODB #6386

Merged
merged 5 commits into from
Mar 23, 2020
Merged

Conversation

jamesaimonetti
Copy link
Member

The faxes DB fills up when the move_doc fails with a conflict when
inserting the doc into the MODB. Handle the error by checking that the
document exists in the MODB and forcing deletion of the doc in the
faxes database.

@jamesaimonetti
Copy link
Member Author

Testing coming, hol' up on merging

@lazedo
Copy link
Member

lazedo commented Mar 18, 2020

@jamesaimonetti i think this doesn't address the case. if the move fails in the attachments part, we're deleting it from FromDB. the simpler fix would be to hard delete the doc in ToDB and let it retry. but the real problem imo, is with the way ensure_saved works now.

The faxes DB fills up when the `move_doc` fails with a conflict when
inserting the doc into the MODB. Handle the error by checking that the
document exists in the MODB and forcing deletion of the doc in the
faxes database.
@lazedo lazedo merged commit bd168f6 into 4.3 Mar 23, 2020
@lazedo lazedo deleted the fax-move-4.3 branch March 23, 2020 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants