PISTON-1002: use collect_digits for DTMF during vm greeting/instructions #6249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@danielfinke rebase here |
danielfinke
force-pushed
the
pr-PISTON-1002-voicemail-operator-number-during-instructions
branch
from
738c325 to
da455f0
Compare
danielfinke
force-pushed
the
pr-PISTON-1002-voicemail-operator-number-during-instructions
branch
from
da455f0 to
1c01c04
Compare
danielfinke
deleted the
pr-PISTON-1002-voicemail-operator-number-during-instructions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
play_greeting_intro,play_greeting, orplay_instructionsplay media, a noop is enqueued.kapps_call_command:wait_for_application_or_dtmfmay continue on the noop from one of these play commands, rather than as expected due tokapps_call_command:noop. This means, for example, the user is unable to press a key to connect to the operator during instructions, if the greeting has already been played.I introduced the 8-arity
collect_digitsfor this purpose, too, as it allows a long initial timeout (kapps_call_command:default_application_timeout) but continues immediately after the expecting noop (the second argument set to 0).