PISTON-979: fix migrating templates from system into accounts #6189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielfinke
force-pushed
the
pr-PISTON-979-cb-notifications-template-migration
branch
from
3273b82 to
f106acf
Compare
|
@danielfinke Thanks. Please also backport this to 4.3. |
danielfinke
deleted the
pr-PISTON-979-cb-notifications-template-migration
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notification template fields such as to, from, cc, bcc were being lost as only the
kz_notification:base_propertieswere being written to the account-local notification doc during migration. This was being missed on the API req that performed the migration as it would succeed because the missing properties had been inherited from the parent/system during the validate step. But then subsequent requests would be missing the properties because the notification template exists in the account and inheritance is therefore not performed.