PISTON-837: Added transcription to metadata & updated docs #5863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build error doesn't seem related to my changes. |
|
Also added a |
|
Try a rebase against master to see if that addresses build errors. Shouldn't this PR also update |
|
I will look into those comments. Thanks James. |
DustinBrett
force-pushed
the
PISTON-837-cb-transcriptions
branch
2 times, most recently
from
04c4c13 to
1d4f16f
Compare
added 4 commits
July 9, 2019 08:31
Transcription data will now be returned with the existing endpoints.
DustinBrett
force-pushed
the
PISTON-837-cb-transcriptions
branch
from
76e0772 to
fb4303c
Compare
Rebased & added |
mark2600
approved these changes
Jul 11, 2019
itlevel3
pushed a commit
to sipengines/kazoo
that referenced
this pull request
Oct 16, 2019
* PISTON-837: Added transcription to metadata & updated docs Transcription data will now be returned with the existing endpoints. * PISTON-837: Added transcribed boolean to list views * PISTON-837: Updated message schema * PISTON-837: Updated OAS3 Schema * PISTON-837: Fix text copy from old version
k-anderson
pushed a commit
that referenced
this pull request
Jan 24, 2020
* PISTON-837: Added transcription to metadata & updated docs Transcription data will now be returned with the existing endpoints. * PISTON-837: Added transcribed boolean to list views * PISTON-837: Updated message schema * PISTON-837: Updated OAS3 Schema * PISTON-837: Fix text copy from old version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transcriptions are being saved outside of the metadata key which is what is returned when information about a voicemail is pulled from crossbar. I had originally considered changing the way transcriptions are saved to move them into metadata but decided on the approach of adding it to the return data upon request so that this will work with pre-existing transcriptions. I’ve updated the crossbar api doc also because now this data will be returned when applicable.