fix an error when move using destination id

2403905 · Feb 6, 2024 · 37109d1 · 37109d1
1 parent bf89f7a
commit 37109d1
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/changelog/unreleased/fix-move.md b/changelog/unreleased/fix-move.md
@@ -0,0 +1,6 @@
+Bugfix: Fix an error when move
+
+We fixed a bug that caused Internal Server Error when move using destination id
+
+https://github.com/cs3org/reva/pull/4503
+https://github.com/owncloud/ocis/issues/6739
diff --git a/internal/http/services/owncloud/ocdav/move.go b/internal/http/services/owncloud/ocdav/move.go
@@ -266,7 +266,11 @@ func (s *svc) handleMove(ctx context.Context, w http.ResponseWriter, r *http.Req
 		}
 		// TODO what if intermediate is a file?
 	}
-
+	// resolve the destination path
+	if dst.Path == "." {
+		dst.Path = utils.MakeRelativePath(dstStatRes.GetInfo().GetName())
+		dst.ResourceId = dstStatRes.GetInfo().ParentId
+	}
 	mReq := &provider.MoveRequest{Source: src, Destination: dst}
 	mRes, err := client.Move(ctx, mReq)
 	if err != nil {