SEC-1493 Added the ability to group linters via linter packs. #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahc23
force-pushed
the
SEC-1493-linter-packs
branch
from
6e7bb9f to
2a0bcc9
Compare
|
Ah doh, I should update the |
sarahc23
force-pushed
the
SEC-1493-linter-packs
branch
from
c3b5cad to
8545696
Compare
sarahc23
force-pushed
the
SEC-1493-linter-packs
branch
from
8545696 to
c161a2a
Compare
sarahc23
commented
Jul 1, 2021
lib/functions/validation.sh
Outdated
| # Build the RUN_*_TOOLS variable | ||
| RUN_LINTER_PACK="RUN_${PACK}" | ||
|
|
||
| for LANGUAGE in "${!LINTERS}"; do |
There was a problem hiding this comment.
Or should I call it LANGUAGE_PACKS to be consistent with their existing use of LANGUAGE (although it'd be more confusing to an end user -- e.g., what the hell's a 'security language pack'?).
There was a problem hiding this comment.
Yes I just feel let's keep it LANGUAGE what they have used just to maintain uniformity.
nandusekarv10
approved these changes
Jul 1, 2021
scriptsrc
approved these changes
Jul 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completely changed VALIDATE_* logic:
true, default tofalseand vice versa' logic. Instead, all languages/linters will default tofalse.true, EXCEPT...VALIDATE_<language>flag for that specific linter, that will override all linter pack settings.