Skip to content

Commit

Permalink
Release 4.0.4
Browse files Browse the repository at this point in the history
  • Loading branch information
Chris Mildebrandt committed Mar 18, 2022
1 parent 87af644 commit d7f9657
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 7 deletions.
7 changes: 1 addition & 6 deletions Makefile
View file
Original file line number Diff line number Diff line change
@@ -1,9 +1,4 @@
define VERSION_SCR
import pkg_resources
print(pkg_resources.require("yamale")[0].version)
endef

VERSION ?= $(shell python -c '$(VERSION_SCR)')
VERSION ?= $(shell cat yamale/VERSION)

all: test

Expand Down
2 changes: 1 addition & 1 deletion yamale/VERSION
View file
Original file line number Diff line number Diff line change
@@ -1 +1 @@
4.0.3
4.0.4

2 comments on commit d7f9657

@rustydb
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am maintaining a pyinstaller project that was using 4.0.2, when we upgrade to 4.0.4 we hit this problem:

Traceback (most recent call last):
  File "cli.py", line 39, in <module>
  File "<frozen importlib._bootstrap>", line 1007, in _find_and_load
  File "<frozen importlib._bootstrap>", line 986, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 680, in _load_unlocked
  File "PyInstaller/loader/pyimod02_importers.py", line 499, in exec_module
  File "generate/generate.py", line 26, in <module>
  File "<frozen importlib._bootstrap>", line 1007, in _find_and_load
  File "<frozen importlib._bootstrap>", line 986, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 680, in _load_unlocked
  File "PyInstaller/loader/pyimod02_importers.py", line 499, in exec_module
  File "generate/network/network.py", line 26, in <module>
  File "<frozen importlib._bootstrap>", line 1007, in _find_and_load
  File "<frozen importlib._bootstrap>", line 986, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 680, in _load_unlocked
  File "PyInstaller/loader/pyimod02_importers.py", line 499, in exec_module
  File "generate/network/config/config.py", line 33, in <module>
  File "<frozen importlib._bootstrap>", line 1007, in _find_and_load
  File "<frozen importlib._bootstrap>", line 986, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 680, in _load_unlocked
  File "PyInstaller/loader/pyimod02_importers.py", line 499, in exec_module
  File "network_modeling/NetworkNodeFactory.py", line 33, in <module>
  File "<frozen importlib._bootstrap>", line 1007, in _find_and_load
  File "<frozen importlib._bootstrap>", line 986, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 680, in _load_unlocked
  File "PyInstaller/loader/pyimod02_importers.py", line 499, in exec_module
  File "yamale/__init__.py", line 4, in <module>
  File "<frozen importlib._bootstrap>", line 1007, in _find_and_load
  File "<frozen importlib._bootstrap>", line 986, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 680, in _load_unlocked
  File "PyInstaller/loader/pyimod02_importers.py", line 499, in exec_module
  File "yamale/version.py", line 6, in <module>
FileNotFoundError: [Errno 2] No such file or directory: '/tmp/_MEIJysRYQ/yamale/VERSION'
[68792] Failed to execute script 'cli' due to unhandled exception!

I think this is an issue with the way we invoke pyinstaller, we want to ditch pyinstaller entirely.

@mildebrandt
Copy link

@mildebrandt mildebrandt commented on d7f9657 Jan 31, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rustydb I don't know anything about pyinstaller (other than what I searched in the last 5 minutes), but it sounds like you need to add the VERSION file to your spec file for it to be included when bundling.

Please sign in to comment.